<p>Enable transaction matching using callid and cseq values<br>
instead of via md5 value.</p>
<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>Hello,</p>
<p>We had an issue with kamailio that the generated tm p_cell->md5 was not sent out in Via "branch=" parameter. Instead, other value was sent. Thus when comparing the replies Via "branch=" md5 value back to p_cell->md5, the transactions mismatched and dialogs were not setup. This happened for the most of the transactions/dialogs.</p>
<p>We could not really figure out why the above was happening. Because this was an isolated system, we decided to do this workaround using callid and cseq matching for transactions, and it helped. Now most of the dialogs are setup.</p>
<p>Let me know what you think, if other had this problem and if this PR helps.</p>
<p>Thank you,<br>
Stefan</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/2868'>https://github.com/kamailio/kamailio/pull/2868</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/kamailio/kamailio/pull/2868/commits/ab42c71fa814a9d2f3d85f10c1519ffd0fdf3369">tm: Add callid_cseq_matching param</a></li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2868/files#diff-9eb47096f4f76aaa591f2f5feb7e25b6bab95478f479291c2b8382e2c80d20eb">src/modules/tm/config.c</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2868/files#diff-a48d1960c71d65f92646ab81ca189d44756e22f4fe86f284902a660f9c5dfa8a">src/modules/tm/config.h</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2868/files#diff-79e44c6ffa7981b7497e407807cd3aad2358d5b5a4c4d0736e973f243de96985">src/modules/tm/doc/params.xml</a>
(23)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2868/files#diff-530586068e0d1632252e08529c32ec4e2c46ecaa5e8a913ed9ad4e5853de493a">src/modules/tm/t_lookup.c</a>
(20)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2868/files#diff-2f844379e353b18e70c9c628fedf857ac85784cf5f1dd468c95d7799bf3d9498">src/modules/tm/tm.c</a>
(1)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/2868.patch'>https://github.com/kamailio/kamailio/pull/2868.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/2868.diff'>https://github.com/kamailio/kamailio/pull/2868.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2868">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZPQWIUZMSMG4TBFOHTUFG25LANCNFSM5FJQLQQA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/ABO7UZIW7ILDNIVWGYU2D5TUFG25LA5CNFSM5FJQLQQKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4PEDSUBA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2868",
"url": "https://github.com/kamailio/kamailio/pull/2868",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>