<p></p>
<p>Thanks for the new module!</p>
<p>I find the name with potential to create confusion, being closed to <code>NAT</code> and we all know how popular that is and what it refers to in VoIP, but at the end I am fine with it given that it is the name of the external project. Maybe in the future if we end up with many distributed messaging platform modules, we can add a common prefix to all of them like we added for db module in the past.</p>
<p>Regarding the code, I noticed that shm/pkg_malloc() results are not checked for NULL, which will result in crashes on low/out of memory cases. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/eschmidbauer/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/eschmidbauer">@eschmidbauer</a> has already git commit access, so I am fine to merge it and then push follow up commits for memory allocation checks.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2790#issuecomment-869451310">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZKHS7YN5JFPHCLSAQ3TVARUZANCNFSM47MJ3QRQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZOVESUHPNRN3KO5S63TVARUZA5CNFSM47MJ3QR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGPJMMLQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2790#issuecomment-869451310",
"url": "https://github.com/kamailio/kamailio/pull/2790#issuecomment-869451310",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>