<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><blockquote type="cite" class=""><p class="">I find the name with potential to create confusion, being closed to <code class="">NAT</code> and we all know how popular that is and what it refers to in VoIP, but at the end I am fine with it given that it is the name of the external project. Maybe in the future if we end up with many distributed messaging platform modules, we can add a common prefix to all of them like we added for db module in the past.</p></blockquote><div class="">“msg_”</div><div class="">“mbr_”</div><div class="">“mbus_”</div><div class=""><br class=""></div><div class="">Adding a prefix is a good thing.</div><div class=""><br class=""></div><div class="">/O<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On 28 Jun 2021, at 09:42, Daniel-Constantin Mierla <<a href="mailto:notifications@github.com" class="">notifications@github.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class=""><br class="webkit-block-placeholder"></div><p class="">Thanks for the new module!</p><p class="">I find the name with potential to create confusion, being closed to <code class="">NAT</code> and we all know how popular that is and what it refers to in VoIP, but at the end I am fine with it given that it is the name of the external project. Maybe in the future if we end up with many distributed messaging platform modules, we can add a common prefix to all of them like we added for db module in the past.</p><p class="">Regarding the code, I noticed that shm/pkg_malloc() results are not checked for NULL, which will result in crashes on low/out of memory cases. <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/eschmidbauer/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/eschmidbauer">@eschmidbauer</a> has already git commit access, so I am fine to merge it and then push follow up commits for memory allocation checks.</p><p style="font-size:small;-webkit-text-size-adjust:none;color:#666;" class="">—<br class="">You are receiving this because you are subscribed to this thread.<br class="">Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2790#issuecomment-869451310" class="">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZKHS7YN5JFPHCLSAQ3TVARUZANCNFSM47MJ3QRQ" class="">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZOVESUHPNRN3KO5S63TVARUZA5CNFSM47MJ3QR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGPJMMLQ.gif" height="1" width="1" alt="" class=""></p>
_______________________________________________<br class="">Kamailio (SER) - Development Mailing List<br class=""><a href="mailto:sr-dev@lists.kamailio.org" class="">sr-dev@lists.kamailio.org</a><br class="">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev<br class=""></div></blockquote></div><br class=""></div></body></html>