<p></p>
<p><a href="https://github.com/kamailio/kamailio/blob/ecc2cc69b08e797ca954af233c229ed44475ce33/src/modules/nathelper/nathelper.c#L1699">https://github.com/kamailio/kamailio/blob/ecc2cc69b08e797ca954af233c229ed44475ce33/src/modules/nathelper/nathelper.c#L1699</a></p>
<p>First of all, using <code>'a=rtcp'</code> in <code>replace_sdp_ip()</code> violates a principle of SoC (<a href="https://en.wikipedia.org/wiki/Separation_of_concerns" rel="nofollow">separation of concerns</a>).<br>
Comparsion with 'a=rtcp' should be made at <code>ki_fix_nated_sdp_ip()</code>. Issue <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="915984974" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2768" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2768/hovercard" href="https://github.com/kamailio/kamailio/issues/2768">#2768</a> is perfect, but merge <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="915990217" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2769" data-hovercard-type="pull_request" data-hovercard-url="/kamailio/kamailio/pull/2769/hovercard" href="https://github.com/kamailio/kamailio/pull/2769">#2769</a> is "some word".</p>
<p>The original  <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="915984974" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2768" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2768/hovercard" href="https://github.com/kamailio/kamailio/issues/2768">#2768</a> (<a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/71441c08970c307e2ce17b2dd292630ea615079c/hovercard" href="https://github.com/kamailio/kamailio/commit/71441c08970c307e2ce17b2dd292630ea615079c"><tt>71441c0</tt></a>) contain bug with out-of-bound.</p>
<p>Later on (<a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/521485c8f25f55cb3045ab2b33232c7026d8527d/hovercard" href="https://github.com/kamailio/kamailio/commit/521485c8f25f55cb3045ab2b33232c7026d8527d"><tt>521485c</tt></a>) it was brought to new problem. Using <code>linelen</code> comparsion with <code>memcmp()</code> avoids appearing an error while "o=xxx" or "c=ccc" (while linelen is less then 6 chars).</p>
<p>I tried to fix it.</p>
<p>It looks like a duct tape. I get the impression, there's no a code review at the project. I think, that you have look even my fix very superficially.</p>
<p>You are very quick-tempered, for any criticism you are answer: "<em>go away</em>", "<em>offend</em>" etc.</p>
<p>P.S. Unfortunately, I didn't have any free time and was unable to review code <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="915984974" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2768" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2768/hovercard" href="https://github.com/kamailio/kamailio/issues/2768">#2768</a> prior to commit.<br>
P.P.S. Can you provide a stoplist of words, that <a href="https://en.wiktionary.org/wiki/dirty_code" rel="nofollow">inappropriate?</a> for using.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2784#issuecomment-864091701">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZOJTPHU5CVI7GM6GI3TTNL6FANCNFSM46ZKJ5VA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZP5Z65RMNJZ65RNQLLTTNL6FA5CNFSM46ZKJ5VKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGOAP4NI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2784#issuecomment-864091701",
"url": "https://github.com/kamailio/kamailio/pull/2784#issuecomment-864091701",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>