<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in doc/ subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="688041435" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2459" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2459/hovercard" href="https://github.com/kamailio/kamailio/issues/2459">#2459</a>, <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="915984974" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2768" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2768/hovercard" href="https://github.com/kamailio/kamailio/issues/2768">#2768</a></li>
</ul>
<h4>Description</h4>
<p>There's a small regression after <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="714677034" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2497" data-hovercard-type="pull_request" data-hovercard-url="/kamailio/kamailio/pull/2497/hovercard" href="https://github.com/kamailio/kamailio/pull/2497">#2497</a>.</p>
<p>If SDP didn't have an "a=rtcp" header (RFC1889 behavior), Kamailio had thrown an Error <code>can't extract 'a=rtcp' IP from the SDP</code> on every INVITE. After the PR Kamailio does not flood into log.</p>
<p>Also refactored <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="915990217" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2769" data-hovercard-type="pull_request" data-hovercard-url="/kamailio/kamailio/pull/2769/hovercard" href="https://github.com/kamailio/kamailio/pull/2769">#2769</a>.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/2784'>https://github.com/kamailio/kamailio/pull/2784</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>nathelper: fix_nated_sdp added ignoring RFC3605-param if omitted</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2784/files#diff-1393aee625cf245c4b3e0e6f5d5dadb79013c9487684cf40398b684a08237fd2">src/modules/nathelper/nathelper.c</a>
    (37)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/2784.patch'>https://github.com/kamailio/kamailio/pull/2784.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/2784.diff'>https://github.com/kamailio/kamailio/pull/2784.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2784">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZI7ZTTFXNZLNHWDSHDTTCJHNANCNFSM46ZKJ5VA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZPKHKJWN7E3NG7BZZ3TTCJHNA5CNFSM46ZKJ5VKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4NX42TPQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2784",
"url": "https://github.com/kamailio/kamailio/pull/2784",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>