<p></p>
<p>It seems to be a conflict looking at the commits in the two PRs, if the offsets are not messing my evaluation -- yours is changing replace_sdp_ip() function with:</p>
<pre><code>-        if(!hasreplaced) {
+       if(!hasreplaced && memcmp("a=rtcp", line, 6) != 0) {
                LM_ERR("can't extract '%s' IP from the SDP\n", line);
                return -1;
        }
</code></pre>
<p>The <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="894345929" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2737" data-hovercard-type="pull_request" data-hovercard-url="/kamailio/kamailio/pull/2737/hovercard" href="https://github.com/kamailio/kamailio/pull/2737">#2737</a> removes there:</p>
<pre><code>-        if(!hasreplaced) {
-               LM_ERR("can't extract '%s' IP from the SDP\n", line);
-               return -1;
-       }
</code></pre>
<p>Maybe <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/dwagin/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/dwagin">@dwagin</a> can check this PR as well.</p>
<p>It has to be decided if they need to be combined or one skipped, ...</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2769#issuecomment-857614445">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZJGCQODWYYADL6Q6ETTR5FULANCNFSM46LURFXQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZPKQD2TCF4WSSGKIMDTR5FULA5CNFSM46LURFX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGMPCQ3I.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2769#issuecomment-857614445",
"url": "https://github.com/kamailio/kamailio/pull/2769#issuecomment-857614445",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>