<p></p>
<p><b>@henningw</b> commented on this pull request.</p>

<p>Thanks for the pull request, i have added one comment regarding the time handling. Are there module any documentation updates necessary as well?</p><hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2731#discussion_r629268266">src/modules/ims_ipsec_pcscf/ipsec.c</a>:</p>
<pre style='color:#555'>> @@ -100,8 +100,15 @@ static void string_to_key(char* dst, const str key_string)
     }
 }
 
+static uint choose_nlmsg_seq (void)
</pre>
<p>Any particular reason why you choose to implement this function instead of the previous time(0) call? The clock_gettime() function is not available at Mac OS, and probably need a wrapper around it as e.g. in the cdp module. If not necessary, we should probably stay with the previous way.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2731#pullrequestreview-655517861">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZM7GYFDMRDZLBOYI7TTM65KVANCNFSM44PQXWGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZODLMT7GTPSWJSBWGLTM65KVA5CNFSM44PQXWG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOE4JGRJI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2731#pullrequestreview-655517861",
"url": "https://github.com/kamailio/kamailio/pull/2731#pullrequestreview-655517861",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>