<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>This is the selectors feature for <code>lost</code> module.<br>
The module still in development but the core functionality is working.<br>
What need to do</p>
<ol>
<li>separate feature into dedicated <code>.c</code> file;</li>
<li>rebase on current <code>lost</code> implementation;</li>
<li>add documentation;</li>
<li>add a unit test.</li>
</ol>
<p>Would be fine if we can merge this into 5.5.</p>
<p>This branch based on <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/e7d68556e3560f488c4f421731f78b3f9abe549e/hovercard" href="https://github.com/kamailio/kamailio/commit/e7d68556e3560f488c4f421731f78b3f9abe549e"><tt>e7d6855</tt></a> commit</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/2705'>https://github.com/kamailio/kamailio/pull/2705</a></p>
<h4>Commit Summary</h4>
<ul>
<li>http_client: http_client_request (api) content-type header support</li>
<li>lost: new features, attributes and a new function to dereference location</li>
<li>lost: bug-fix due to a code formatting error</li>
<li>lost: DOM level count fix</li>
<li>http_client: duplicated code removed</li>
<li>lost: README update</li>
<li>lost: memory leak fix and code refactoring</li>
<li>lost: implemented sectors</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-84ce34ef4f37934a5b0aae53608750749d061606e1a4663b1cd5f272e8cd3d29">src/modules/http_client/curl_api.c</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-6f821d003208fa5eabb504997d41d185dccfe6ff406bd496bf5a250a63c30150">src/modules/http_client/curl_api.h</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-1282e7db0982377302511140b8e41cd3e415448e88bf70d77e2bd31fea61723e">src/modules/http_client/functions.c</a>
(30)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-67e077f66f41822d6a1f64f93c6caedccbc870c6c1a70b176137b2ab062c639f">src/modules/http_client/functions.h</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-0b7b580084dfdd6da7ffe5a0c2de1068a62e02789e15750960d67d1be83245d9">src/modules/lost/doc/lost.xml</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-7ba9437dd18036c4bc3680722298ca20e6df0714388dd20e72f72f5a6849288a">src/modules/lost/doc/lost_admin.xml</a>
(172)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-ce5a836bafb7dbb891ebd02559e0e3226ccc2a81c6efec979e9e05d6a45aee6a">src/modules/lost/functions.c</a>
(921)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-6530391fbb7a28f161fd5bfae3d8150e899fb5b91498fac227b3eda371cd0af2">src/modules/lost/functions.h</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-e0da00ced9a66f2d6980fdf73e09ba5ad80aaf17209c52e52b614c6a984b5b82">src/modules/lost/lost.c</a>
(754)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-049566078c0d10268f194345eb77c0492f57175b3afad511cea261c7f561b4bc">src/modules/lost/naptr.c</a>
(255)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-55d6361f1fdc5c95887553abfe4a89d613281f41a2cab2230fce2f27bcdf6547">src/modules/lost/naptr.h</a>
(38)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-e3c155a776f00520b46e3056fcef7f14bcae900682383e68a98df552edd81ba3">src/modules/lost/pidf.c</a>
(5)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-e9459b8b0a59b4bc1b1d7c51497f92211558c7bc4490133c0668bd307d9571b0">src/modules/lost/response.c</a>
(991)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-ed4b7a73b9547e599886dd7c8afa10b2fd26b7fbdc1941be375cb6c836235928">src/modules/lost/response.h</a>
(131)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-c4f8270cc65720aab16963ad276c57dc60e50223a05e921d8865156a21380d86">src/modules/lost/utilities.c</a>
(532)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2705/files#diff-9ec3016ffd33d28eab668c592bca05230478fb4be2f3108697b1afe96cec38f8">src/modules/lost/utilities.h</a>
(65)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/2705.patch'>https://github.com/kamailio/kamailio/pull/2705.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/2705.diff'>https://github.com/kamailio/kamailio/pull/2705.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2705">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZIQ25H37BQDXSXASA3TH5UZ5ANCNFSM42VV37LA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZIGV2N4JT7ULQYK7ULTH5UZ5A5CNFSM42VV37LKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MXUC7DQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2705",
"url": "https://github.com/kamailio/kamailio/pull/2705",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>