<p></p>
<h3>Description</h3>
<p>When updating from Kamailio 5.2.2 to 5.4.4, we're encountering an issue: the pua_dialoginfo module publishes a <code>confirmed</code> state for the dialog, even though it's still ringing.</p>
<p>It turns out this commit introduces the problem since 5.3.0: <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/4efe19f64d8bb787d2d620a833f5dd29619fa588/hovercard" href="https://github.com/kamailio/kamailio/commit/4efe19f64d8bb787d2d620a833f5dd29619fa588"><tt>4efe19f</tt></a></p>
<p>So since 5.3.0, the dialog module (i think correctly?) sends out state updates for PRACK dialog updates as <code>DLGCB_REQ_WITHIN</code> events. But the <code>pua_dialoginfo</code> module seems to see that as a signal to mark the dialog confirmed (see <a href="https://github.com/kamailio/kamailio/blob/master/src/modules/pua_dialoginfo/pua_dialoginfo.c#L311">here</a>).</p>
<p>One easy fix would be to simply remove <code>DLGCB__REQ_WITHIN</code> from the case list in pua_dialoginfo?</p>
<p>OpenSER <a href="https://github.com/OpenSIPS/opensips/blob/master/modules/pua_dialoginfo/pua_dialoginfo.c#L353">seems to</a> ditch the <code>DLGCB_REQ_WITHIN</code> messages altogether, for specific messages...</p>
<h3>Troubleshooting</h3>
<h4>Reproduction</h4>
<ul>
<li>Use the pua_dialoginfo module</li>
<li>Make sure your device uses PRACK</li>
<li>See that the dialog is confirmed even before you pick up; watch for log lines: <code>__dialog_sendpublish(): dialog confirmed</code></li>
</ul>
<h4>Debugging Data</h4>
<p>N/A</p>
<h4>Log Messages</h4>
<p>With 5.4.4:</p>
<pre><code>2021-04-02T16:49:44.453339+02:00 debug proxy[17964]: DEBUG: pua_dialoginfo [pua_dialoginfo.c:295]: __dialog_sendpublish(): dialog confirmed, from=sip:220@188.166.42.37
</code></pre>
<h4>SIP Traffic</h4>
<p>Just a regular invite with prack.</p>
<h3>Possible Solutions</h3>
<p>See above.</p>
<h3>Additional Information</h3>
<p>Reproduced with Kamailio 5.4.4, but probably all versions from 5.3.0 are affected.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/issues/2700">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZOUCAMQYV3FG5ZR62DTGXO2RANCNFSM42JAXILQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZKOIT22AUGFMUHAFNLTGXO2RA5CNFSM42JAXIL2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4MU7AIIQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/issues/2700",
"url": "https://github.com/kamailio/kamailio/issues/2700",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>