<p></p>
<p>Few comments on the module being ready to merge :</p>
<ul>
<li>I noticed the module interface was outdated it should be tested one more time, <code>child_init</code> and <code>mod_init</code> may not be working.</li>
<li>The documentation is good however it is made in the README instead of the XML files</li>
<li>Based on my quick tests there was an unexpected performance degradation seen this may not be a real concern if the module is mainly still an alpha POC</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2208#issuecomment-780015058">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZNQ7GN3U4PGCG6JILTS7KW7XANCNFSM4KMQMZBQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZOCX2JHOMLSZ6XTSULS7KW7XA5CNFSM4KMQMZB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFZ7BLUQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2208#issuecomment-780015058",
"url": "https://github.com/kamailio/kamailio/pull/2208#issuecomment-780015058",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>