<p></p>
<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/korayvt/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/korayvt">@korayvt</a> - a variant that keeps also the backward compatibility is to go over the list of connections parameters and if <code>connect_timeout</code> is missing, then add it like it is done now, when <code>pg_timeout>0</code>.</p>
<p>On another aspect, I would suggest to go for the style of 'param_name=param_value", it seems that the postgres param names are compatible with sip param names, as I can see at the link you provided:</p>
<ul>
<li><a href="https://www.postgresql.org/docs/12/libpq-connect.html#LIBPQ-PARAMKEYWORDS" rel="nofollow">https://www.postgresql.org/docs/12/libpq-connect.html#LIBPQ-PARAMKEYWORDS</a></li>
</ul>
<p>So instead of:</p>
<pre><code>modparam("db_postgres", "con_param", "name=connect_timeout;value=15")
modparam("db_postgres", "con_param", "name=tcp_user_timeout;value=5000")
</code></pre>
<p>It can be:</p>
<pre><code>modparam("db_postgres", "con_param", "connect_timeout=15")
modparam("db_postgres", "con_param", "tcp_user_timeout=5000")
</code></pre>
<p>And the above can also be compacted to:</p>
<pre><code>modparam("db_postgres", "con_param", "connect_timeout=15;tcp_user_timeout=5000")
</code></pre>
<p>It would require some changes in function <code>postgres_con_param()</code>.</p>
</blockquote>
<p>Hi Daniel,</p>
<p>I will consider your suggestions and make a new commit.</p>
<p>Thanks.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2622#issuecomment-773822689">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZITRPWPMZZCUNJ2CE3S5OFTRANCNFSM4XCJSFIA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZOZVDZ74PS7KEKLU7TS5OFTRA5CNFSM4XCJSFIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFYPZRYI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2622#issuecomment-773822689",
"url": "https://github.com/kamailio/kamailio/pull/2622#issuecomment-773822689",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>