<p>pua_dialoginfo: Add display attributes to identity tags.</p>
<ul>
<li>This is an example of how "display" attributes could be added to identity tags in the PUBLISH message XML body.</li>
<li>This is not a working solution, the strings("RemoteCallerName" & "LocalCallerName") are "hard coded". I could not figure out how to get the caller/callee information from the SIP message.</li>
</ul>


<h4>Pre-Submission Checklist</h4>



<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>

<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="798548285" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2615" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2615/hovercard" href="https://github.com/kamailio/kamailio/issues/2615">#2615</a></li>
</ul>
<h4>Description</h4>
<p>This is not a working solution. Opening the PR as requested by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/miconda/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/miconda">@miconda</a> in issue <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="798548285" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2615" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2615/hovercard" href="https://github.com/kamailio/kamailio/issues/2615">#2615</a>. I just added a couple lines to test how adding a "display" attribute to the identity tags would look like. This allows the phone to update it's display with relevant caller/callee information. I "hard coded" the values to verify that this works. However, I could not figure out how to get the display name from the SIP message(I'm not experienced with C).</p>
<p>It seems that the "local" identity should have it's display name set to the name in the From header. And, the remote identity should have its display name set to the user part of the URI in the "To" header.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/2617'>https://github.com/kamailio/kamailio/pull/2617</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Create dialog_publish.c</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2617/files#diff-f22e8d9ff5d56c7724926d35407e40ad0d05f16f6fa318bb0d1ffad2c6de4aa5">src/modules/pua_dialoginfo/dialog_publish.c</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/2617.patch'>https://github.com/kamailio/kamailio/pull/2617.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/2617.diff'>https://github.com/kamailio/kamailio/pull/2617.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2617">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZKBGZZISRS4MPPVK2DS44I2LANCNFSM4W5OVJKA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZOQCIJPEMNZ3YGI62DS44I2LA5CNFSM4W5OVJKKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4L43HTYQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2617",
"url": "https://github.com/kamailio/kamailio/pull/2617",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>