<p></p>
<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/wkampich/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/wkampich">@wkampich</a> regarding the code implementation - i looked also briefly into it. You took over some code from the enum module. If this is done copy and paste way, i.e. the same code in the enum module, we should probably think about moving this to the core. If you modified the code in different places, then probably the copyright notice of the original module needs to be added as well to your code.</p>
<p>Close this PR, as discussed in previous comments.</p>
</blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/henningw/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/henningw">@henningw</a> There are indeed some functions copied from enum, perhaps it is good idea to have common NAPTR lookup utilities in the core.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2606#issuecomment-768448863">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZOFKU7ZCDQC7OQ5ATTS4BEXDANCNFSM4WQWC7JQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZKQJZB7T2PYMK32VA3S4BEXDA5CNFSM4WQWC7J2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFXGZSXY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2606#issuecomment-768448863",
"url": "https://github.com/kamailio/kamailio/pull/2606#issuecomment-768448863",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>