<p></p>
<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2595#discussion_r551770652">src/core/socket_info.c</a>:</p>
<pre style='color:#555'>> @@ -1184,6 +1189,16 @@ static int build_iface_list(void)
                nll = 0;
                p = buf;
                while(1) {
+                       // This (and the loop above in get_flags) is
+                       // broken in more than one aspect. For example,
+                       // if a receive is shorter than nlmsghdr,
+                       // nlp->nlmsg_type will point at garbage.
+                       // Proper fix for this (and static buffer sizing
+                       // problem) would be to use libnl.
</pre>
<p>This comment does not belong in the source code.</p>
<p>If there is still any issue left after this commit, then report it in the issue tracker. The developers do not scan the code for comments pointing at possible issues.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2595#pullrequestreview-561579800">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZMOAJ7K2TB3LLFFRZ3SYLBQZANCNFSM4VTC6VXA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZJGWTEAJXJXGM5VOFDSYLBQZA5CNFSM4VTC6VXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEF4QOGA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2595#pullrequestreview-561579800",
"url": "https://github.com/kamailio/kamailio/pull/2595#pullrequestreview-561579800",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>