<p></p>
<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2556#discussion_r530149970">src/modules/smsops/smsops_impl.c</a>:</p>
<pre style='color:#555'>> @@ -618,6 +627,7 @@ int decode_3gpp_sms(struct sip_msg *msg) {
                                        // Coding: 7 Bit
                                        if (rp_data->pdu.coding == 0x00) {
                                                // We don't care about the extra used bytes here.
+                                               rp_data->pdu.payload.sm.len = len;
                                                rp_data->pdu.payload.sm.len = gsm_to_ascii(&body.s[p], len, rp_data->pdu.payload.sm, fill_bits);
</pre>
<p>OK, I will merge it. Somehow confusing is that <code>len</code> is also explicitly passed as a parameter to that function.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2556#discussion_r530149970">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZPUNHLCLT4HKIPLMQTSRSU6ZANCNFSM4T3NTFHQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZJQU3NS2BI7LUYKTQ3SRSU6ZA5CNFSM4T3NTFH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOEAKGPBI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2556#discussion_r530149970",
"url": "https://github.com/kamailio/kamailio/pull/2556#discussion_r530149970",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>