<p></p>
<p><b>@jchavanton</b> commented on this pull request.</p>

<p>In the issue I am sharing a simple ACK with an IP in the RURI, I am guessing this is taking place everytime, since there is no NAPTR record for the IP address, maybe you need more than one DNS server or something, I wanted to avoid getting dragged in spending to much time since just by looking at the code I can see we are now accepting to do <code>dns_get_entry</code> on IP addresses.</p>
<p>However if this is raising more concerns, I can help to troubleshoot further.</p><hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2541#discussion_r518082562">src/core/dns_cache.c</a>:</p>
<pre style='color:#555'>> @@ -3292,6 +3292,9 @@ inline static int dns_naptr_sip_resolve(struct dns_srv_handle* h,  str* name,
                }
                try_lookup_naptr = 1;
        }
+       /* check if it's an ip address, dns_srv_sip_resolve will return the right failure */
</pre>
<p>Hi, thanks for having a look.</p>
<p>Since you moved <code>dns_get_entry</code> outside of the following check, it can now be executed without checking for IP.</p>
<pre><code>if (((h->srv==0) && (h->a==0)) && /* first call */
                         proto && port && (*proto==0) && (*port==0)){
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2541#pullrequestreview-524302084">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZKOOCEPOAI47PQQUOLSOKZ3LANCNFSM4TKRVY4A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZNEKTYOFRACZQLAA3LSOKZ3LA5CNFSM4TKRVY4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD5ADOBA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2541#pullrequestreview-524302084",
"url": "https://github.com/kamailio/kamailio/pull/2541#pullrequestreview-524302084",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>