<p><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="389826114" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/1762" data-hovercard-type="pull_request" data-hovercard-url="/kamailio/kamailio/pull/1762/hovercard" href="https://github.com/kamailio/kamailio/pull/1762">#1762</a> ## Pre-Submission Checklist</p>



<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>

<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>

<p>Fix invalid JSON returned by stats.fetch with multiple modules as parameter.</p>
<p>Cleanup by reducing code duplication.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/2537'>https://github.com/kamailio/kamailio/pull/2537</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>kex: Make stats.fetch(n) reply with valid JSON</li>
  <li>kex: Remove a lot of duplicate code from rpc_stats_fetch*</li>
  <li>kex: Let the RPC server do printf as it may have optimizations</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2537/files#diff-643508cc9fa3f15278e593da85ce2fb3659d5a6f898a0fa33fc0000aa1c5de9d">src/modules/kex/core_stats.c</a>
    (222)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/2537.patch'>https://github.com/kamailio/kamailio/pull/2537.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/2537.diff'>https://github.com/kamailio/kamailio/pull/2537.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2537">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZMRJWCUZJ2IZJ5ZXZDSNF3Y7ANCNFSM4TDZ3TPQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZMPL5CRIUQQ5NJGZDDSNF3Y7A5CNFSM4TDZ3TP2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4K5G7R2Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2537",
"url": "https://github.com/kamailio/kamailio/pull/2537",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>