<p></p>
<p>The initial version of freeradius-client, which kamailio was cross-compiled against, had the vendor id shifted by 16 bits. It was changed to 8 bits after <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="167790932" data-permission-text="Title is private" data-url="https://github.com/FreeRADIUS/freeradius-client/issues/72" data-hovercard-type="issue" data-hovercard-url="/FreeRADIUS/freeradius-client/issues/72/hovercard" href="https://github.com/FreeRADIUS/freeradius-client/issues/72">FreeRADIUS/freeradius-client#72</a> which as stated was a minor improvement since "private enterprise numbers aren't yet at 16 bits" and collisions were not that possible. Later on freeradius-client completely removed <code>VENDOR()</code> as part of a different way of handling vendor ids.</p>
<p>Also radcli uses 16 bits for shifting vendor id as seen here <a href="https://github.com/radcli/radcli/blob/f0d1a1704595d62182d6a03c980ed07e906374a4/include/radcli/radcli.h#L56">https://github.com/radcli/radcli/blob/f0d1a1704595d62182d6a03c980ed07e906374a4/include/radcli/radcli.h#L56</a></p>
<p>so it made more sense to me, to keep 16 bits shifting to both libraries.</p>
<p>I should note, that adding <code>VENDOR()</code> is more of a quick workaround at this point to allow kamailio to compile against both libraries with minimum effort. Otherwise a different implementation should be used by kamailio if freeradius-client is used</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2530#issuecomment-718096316">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZP67L5FBI6IPY7OEVLSNBJFLANCNFSM4S5A6TMQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZLVKWY2Z6IZ3P5KUI3SNBJFLA5CNFSM4S5A6TM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFLGUPPA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2530#issuecomment-718096316",
"url": "https://github.com/kamailio/kamailio/pull/2530#issuecomment-718096316",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>