<h4>Pre-Submission Checklist</h4>



<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Cleanup</li>
</ul>
<h4>Checklist:</h4>

<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>

<p>Redefine some flags as enum instead of separate define. This makes it easier to see what flags are accepted by functions and with the right compiler flags, the compiler will warn when the wrong flags are used.</p>
<p>No functional changes are intended.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/2511'>https://github.com/kamailio/kamailio/pull/2511</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>core/tcp: Convert RD_CONN_ flags to enum</li>
  <li>core/ip_addr: Reformat and redefine si_flags as bitshifts</li>
  <li>core/ip_addr: Convert SND_F_ flags to enum</li>
  <li>core/tcp: Convert F_TCP_REQ_ flags to enum</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2511/files#diff-35f793f1142eeb48c341e589f23aa13f93c549f7ee529349e30313b0a2468255">src/core/ip_addr.h</a>
    (18)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2511/files#diff-3d9813af3b37d44ce304bfaa9f2bf231e1e4c1ad84838c1b06b1e04ac5cf658e">src/core/tcp_conn.h</a>
    (43)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2511/files#diff-36cd0695584b8b5c383049dc1624d44047ba2ca02eaf15d3bee4b0c1f47178ac">src/core/tcp_read.c</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2511/files#diff-91b155a6329d78fea71e6731e6e7217a89ac880f53edfd6305118e4fd8a19505">src/core/tcp_read.h</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2511/files#diff-3fcbefc4f3ce211b601c968ce6ef34b7fb337d2cf2bf7cf3865df8f6f608d2cf">src/core/tls_hooks.h</a>
    (3)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2511/files#diff-6942b257af79dcb2be5a6df5cf7935833e08fcc93bf4222d18e563dbc2b6c886">src/modules/tls/tls_server.c</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2511/files#diff-300b708e9292552579c249557f22d99f806e4a314a3f6e9219b3945db6b1e5db">src/modules/tls/tls_server.h</a>
    (3)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/2511.patch'>https://github.com/kamailio/kamailio/pull/2511.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/2511.diff'>https://github.com/kamailio/kamailio/pull/2511.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2511">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZIOK3FCB5H5GVXZDFLSLQYLTANCNFSM4SWDEG7A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZJ74HGZQAZFRHR6PU3SLQYLTA5CNFSM4SWDEG7KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4KZQFTTA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2511",
"url": "https://github.com/kamailio/kamailio/pull/2511",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>