<div dir="ltr"><div></div><div>I would have selected #2 even if it is not clear just by reading config file if they will cumulate or override.<br></div><div><br></div><div>Now you will be asked to support both :)</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Oct 5, 2020 at 8:38 AM Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Hello,</p>
<p>the problem I see with 1) is in case one wants to set there SIP
URI for other transports than UDP, the ; is used to separate URI
parameters as well. I think now it supports only UDP anyhow, but
to have it open for future, this should be kept in mind<br>
</p>
<p>From my point of view, for the modules I work with and develop,
the style of separating with ; within same modparam value suits
for sip-params-like-values, respectively
name1=value1;name2=value2; ... because parase param function can
be used. In this case, a value can contain ; but the entire value
has to be enclosed in quotes.</p>
<p>So far 1) maybe another delimiter between URIs should be used,
like comma.</p>
<p>Personally I would like more for 2), it is more compact in case
one uses many addresses, not to have a single very long value, but
I don't really mind 1) with a different separator (at the end both
variants can be supported :-) , but more coding is needed, without
much benefits ...)</p>
<p>Cheers,<br>
Daniel<br>
</p>
<div>On 05.10.20 17:25, Henning Westerholt
wrote:<br>
</div>
<blockquote type="cite">
<div>
<p class="MsoNormal">Hello,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span lang="EN-GB">one question about a
planned extension in the DMQ module. Right now the module
supports only one server in the notification_address
parameter. It is possible to set multi_notify to 1, and then
the module will resolve the one sip URI over DNS to multiple
servers, thought.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">There is interest in
extending the module to support multiple
notification_address servers natively without using DNS. I
see two options right now:<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<ol style="margin-top:0cm" type="1" start="1">
<li style="margin-left:18pt"><span lang="EN-GB">Separate the multiple servers, with “;”, e.g.
modparam(“dmq”, “notification_address”,
“<a>sip:server1;sip:server2”</a>). If only one server in the
param, use the existing logic.<u></u><u></u></span></li>
<li style="margin-left:18pt"><span lang="EN-GB">Use multiple notification_servers parameter
calls, e.g. modparam(“dmq”, “notification_address”) -
modparam(“dmq”, “notification_address”, “<a>sip:server2”</a>). If
only one param statement, use the existing logic.<u></u><u></u></span></li>
</ol>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">As the module already
has support to use a notification server list internally,
the change should be small in both cases.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">I think option 1) is the
better way, as its already done in other modules like this
to support multiple server scenarios.<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">Any comments or
objections about this extension?<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">Cheers,<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB">Henning<u></u><u></u></span></p>
<p class="MsoNormal"><span lang="EN-GB"><u></u> <u></u></span></p>
<p class="MsoNormal">-- <u></u><u></u></p>
<p class="MsoNormal">Henning Westerholt – <a href="https://skalatan.de/blog/" target="_blank"><span style="color:rgb(5,99,193)">https://skalatan.de/blog/</span></a><u></u><u></u></p>
<p class="MsoNormal">Kamailio services – <a href="https://gilawa.com/" target="_blank"><span style="color:rgb(5,99,193)">https://gilawa.com</span></a>
<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
Kamailio (SER) - Development Mailing List
<a href="mailto:sr-dev@lists.kamailio.org" target="_blank">sr-dev@lists.kamailio.org</a>
<a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<pre cols="72">--
Daniel-Constantin Mierla -- <a href="http://www.asipto.com" target="_blank">www.asipto.com</a>
<a href="http://www.twitter.com/miconda" target="_blank">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda" target="_blank">www.linkedin.com/in/miconda</a>
Funding: <a href="https://www.paypal.me/dcmierla" target="_blank">https://www.paypal.me/dcmierla</a></pre>
</div>
_______________________________________________<br>
Kamailio (SER) - Development Mailing List<br>
<a href="mailto:sr-dev@lists.kamailio.org" target="_blank">sr-dev@lists.kamailio.org</a><br>
<a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev" rel="noreferrer" target="_blank">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</blockquote></div>