<p></p>
<p><b>@NGSegovia</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/kamailio/kamailio/pull/2474#discussion_r486425511">src/modules/keepalive/keepalive_api.c</a>:</p>
<pre style='color:#555'>> + lock_get(target->lock);
+ free_destination(target); // Lock is released and freed in this free function
if(!head){
LM_DBG("There isn't any head so maybe it is first \r\n");
ka_destinations_list->first = target->next;
- free_destination(target);
- ka_unlock_destination_list();
- return 1;
+ } else {
+ head->next = target->next;
}
- head->next = target->next;
- free_destination(target);
ka_unlock_destination_list();
</pre>
<p>Opps, thanks for the catch <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/linuxmaniac/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/linuxmaniac">@linuxmaniac</a></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2474#discussion_r486425511">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZL264AOTQFHN3MZYSTSFDUTZANCNFSM4RFBVJ4Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZNGV7V7S3VUIVZJP5TSFDUTZA5CNFSM4RFBVJ42YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODT4HDBY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2474#discussion_r486425511",
"url": "https://github.com/kamailio/kamailio/pull/2474#discussion_r486425511",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>