<p></p>
<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2390#discussion_r449668073">src/modules/nathelper/nathelper.c</a>:</p>
<pre style='color:#555'>> @@ -704,10 +707,12 @@ static int fix_nated_contact_f(struct sip_msg *msg, char *str1, char *str2)
  * Replaces ip:port pair in the Contact: field with the source address
  * of the packet.
  */
-static int set_contact_alias(struct sip_msg *msg)
+static int set_contact_alias(struct sip_msg *msg, int trim)
</pre>
<p>By changing the signature of <code>set_contact_alias()</code> you broke the kemi export of it.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2390#pullrequestreview-442519198">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZOPZ3AAAUW6MTMCGILRZYJLNANCNFSM4OP7A5IA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZJ3UVD7MOPTQSWDBV3RZYJLNA5CNFSM4OP7A5IKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODJQE5HQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2390#pullrequestreview-442519198",
"url": "https://github.com/kamailio/kamailio/pull/2390#pullrequestreview-442519198",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>