<div dir="ltr"><div dir="ltr">Hello Daniel<div><br></div><div>thanks a lot</div><div><br></div><div>Regards</div><div>david</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">El lun., 6 abr. 2020 a las 13:22, Daniel-Constantin Mierla (<<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>>) escribió:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Hello,</p>
<p>apparently it was not backported to 5.3, somehow I forgot about
it. I just did it a few minutes ago.</p>
<p>Cheers,<br>
Daniel<br>
</p>
<div>On 06.04.20 10:49, David Escartin
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">Dear Daniel
<div><br>
</div>
<div>hope everything is ok.</div>
<div>Sorry if i missed something, but has been this patch
already backported from master to 5.3 yet?</div>
<div><br>
</div>
<div>thanks alot and regards</div>
<div>david</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">El jue., 13 feb. 2020 a las
18:12, David Escartin (<<a href="mailto:descartin@sonoc.io" target="_blank">descartin@sonoc.io</a>>)
escribió:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">hello Daniel
<div><br>
</div>
<div>i have tried it and seems fine. </div>
<div><br>
</div>
<div>thanks a lot and regards</div>
<div>david</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">El jue., 13 feb. 2020 a
las 17:13, Daniel-Constantin Mierla (<<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>>)
escribió:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<p>Hello,</p>
<p>indeed keeping route block index in unsigned it can
create problems. I pushed a patch for it:</p>
<p> -
<a href="https://github.com/kamailio/kamailio/commit/6c557efc1b9cb8c880a05235c94780bbaf305073" target="_blank">https://github.com/kamailio/kamailio/commit/6c557efc1b9cb8c880a05235c94780bbaf305073</a></p>
<p>Can you try and see if now works ok? If yes, it
will be backported.</p>
<p>Cheers,<br>
Daniel<br>
</p>
<p><br>
</p>
<div>On 13.02.20 13:27, David Escartin wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hello all
<div><br>
</div>
<div>Testing dialog timeout event callback for
kemi lua setup on kamailio 5.4.0-dev3
(x86_64/linux) d74157-dirty, i had some problems
to perform the dlg timeroute behaviour the same
as we could on native version.</div>
<div>If i used KSR.dialog.var_sets to set
$dlg_ctx(timeout_route), I saw that on a dialog
timeout, the dlg_ontimeout event route was not
triggered, and only the dialog callback was
executed with evname dialog:end. (only executing
event_route -1 on state 5)</div>
<div>So i'm guessing that the kemi dialog var_sets
is for $dlg_var only (¿?)</div>
<div>Anycase, If i used KSR.pv.sets, i saw the
kamailio was crashing</div>
<div>.....</div>
<div>16(5579) DEBUG: dialog [dlg_hash.c:1013]:
dlg_ref_helper(): ref dlg 0x7f9a961f5f90 with 1
-> 3<br>
16(5579) DEBUG: dialog [dlg_handlers.c:1589]:
dlg_ontimeout(): executing route -1 on timeout<br>
22(5645) CRITICAL: <core>
[core/pass_fd.c:277]: receive_fd(): EOF on 8<br>
22(5645) DEBUG: <core>
[core/tcp_main.c:3762]: handle_ser_child(): dead
child 16, pid 5579 (shutting down?)<br>
</div>
<div>....</div>
<div>Adding some debug, i could see that the call
was not attempting the kemi function of line
1598 of dlg_handlers.c, and was trying the code
i think was for native on line 1593.</div>
<div>We think the issue is that the toroute is
defined as unsigned</div>
<div>dlg_hash.h: unsigned int toroute;
/*!< index of route that is executed on
timeout */<br>
</div>
<div>but after that when
setting $dlg_ctx(timeout_route) with pv module,
it tries to compare an integer being unsigned,
so it's always true and never uses kemi</div>
<div>with this change we made it work</div>
<div>+ if
((int)(dlg->toroute) > 0) {<br>
+
/*if(dlg->toroute>0) {*/<br>
</div>
<div>but i don't know maybe there is a better way
to do it.</div>
<div><br>
</div>
<div>best regards</div>
<div>david</div>
</div>
<br>
<fieldset></fieldset>
<pre>_______________________________________________
Kamailio (SER) - Development Mailing List
<a href="mailto:sr-dev@lists.kamailio.org" target="_blank">sr-dev@lists.kamailio.org</a>
<a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev</a>
</pre>
</blockquote>
<pre cols="72">--
Daniel-Constantin Mierla -- <a href="http://www.asipto.com" target="_blank">www.asipto.com</a>
<a href="http://www.twitter.com/miconda" target="_blank">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda" target="_blank">www.linkedin.com/in/miconda</a>
Kamailio Advanced Training - March 9-11, 2020, Berlin - <a href="http://www.asipto.com" target="_blank">www.asipto.com</a>
Kamailio World Conference - April 27-29, 2020, in Berlin -- <a href="http://www.kamailioworld.com" target="_blank">www.kamailioworld.com</a></pre>
</div>
</blockquote>
</div>
</blockquote>
</div>
</div>
</blockquote>
<pre cols="72">--
Daniel-Constantin Mierla -- <a href="http://www.asipto.com" target="_blank">www.asipto.com</a>
<a href="http://www.twitter.com/miconda" target="_blank">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda" target="_blank">www.linkedin.com/in/miconda</a></pre>
</div>
</blockquote></div></div>