<h4>Pre-Submission Checklist</h4>



<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>

<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="606108823" data-permission-text="Title is private" data-url="https://github.com/kamailio/kamailio/issues/2300" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/2300/hovercard" href="https://github.com/kamailio/kamailio/issues/2300">#2300</a></li>
</ul>
<h4>Description</h4>
<p>from <a href="https://github.com/redis/hiredis#using-replies">https://github.com/redis/hiredis#using-replies</a></p>
<blockquote>
<p>The standard replies that redisCommand are of the type redisReply. The type field in the redisReply should be used to test what kind of reply was received:</p>
<ul>
<li>
<p>REDIS_REPLY_STATUS:<br>
The command replied with a status reply. The status string can be accessed using reply->str. The length of this string can be accessed using reply->len.</p>
</li>
<li>
<p>REDIS_REPLY_ERROR:<br>
The command replied with an error. The error string can be accessed identical to REDIS_REPLY_STATUS.</p>
</li>
</ul>
</blockquote>
<p>adding checks for the reply type to detect command errors</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/2314'>https://github.com/kamailio/kamailio/pull/2314</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>ndb_redis: redis_cmd() check reply type to detect command errors</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2314/files#diff-812f223c66f926088d3aa98c36d96b92">src/modules/ndb_redis/redis_client.c</a>
    (13)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/2314.patch'>https://github.com/kamailio/kamailio/pull/2314.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/2314.diff'>https://github.com/kamailio/kamailio/pull/2314.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2314">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZPLY7QXQNUUEWELMKLRQAB6JANCNFSM4MZRE3IA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZJDWXHIIUOEHLJWJELRQAB6JA5CNFSM4MZRE3IKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4JEDCA5A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2314",
"url": "https://github.com/kamailio/kamailio/pull/2314",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>