<p></p>
<p>This commit is changing the keepalive exported api and the modules using it don't build anymore, for now drouting is reported by LGTM analysis to be broken:</p>
<pre><code>[2020-05-04 14:29:31] [build] CC (gcc) [M drouting.so]           drouting.o
[2020-05-04 14:29:31] [build] drouting.c: In function ‘dr_update_keepalive’:
[2020-05-04 14:29:31] [build] drouting.c:226:26: warning: passing argument 4 of ‘keepalive_api.add_destination’ makes integer from pointer without a cast [-Wint-conversion]
[2020-05-04 14:29:31] [build]   226 |     &cur->ip, &owner, 0, dr_keepalive_statechanged, cur);
[2020-05-04 14:29:31] [build]       |                          ^~~~~~~~~~~~~~~~~~~~~~~~~
[2020-05-04 14:29:31] [build]       |                          |
[2020-05-04 14:29:31] [build]       |                          void (*)(str *, ka_state,  void *) {aka void (*)(struct _str *, int,  void *)}
[2020-05-04 14:29:31] [build] drouting.c:226:26: note: expected ‘int’ but argument is of type ‘void (*)(str *, ka_state,  void *)’ {aka ‘void (*)(struct _str *, int,  void *)’}
[2020-05-04 14:29:31] [build] drouting.c:226:53: warning: passing argument 5 of ‘keepalive_api.add_destination’ from incompatible pointer type [-Wincompatible-pointer-types]
[2020-05-04 14:29:31] [build]   226 |     &cur->ip, &owner, 0, dr_keepalive_statechanged, cur);
[2020-05-04 14:29:31] [build]       |                                                     ^~~
[2020-05-04 14:29:31] [build]       |                                                     |
[2020-05-04 14:29:31] [build]       |                                                     pgw_t * {aka struct pgw_ *}
[2020-05-04 14:29:31] [build] drouting.c:226:53: note: expected ‘ka_statechanged_f’ {aka ‘void (*)(struct _str *, int,  void *)’} but argument is of type ‘pgw_t *’ {aka ‘struct pgw_ *’}
[2020-05-04 14:29:31] [build] drouting.c:225:3: error: too few arguments to function ‘keepalive_api.add_destination’
[2020-05-04 14:29:31] [build]   225 |   keepalive_api.add_destination(
[2020-05-04 14:29:31] [build]       |   ^~~~~~~~~~~~~
[2020-05-04 14:29:32] [build] make[2]: *** [../../Makefile.rules:100: drouting.o] Error 1
[2020-05-04 14:29:32] [build] make[1]: *** [Makefile:511: modules] Error 1
[2020-05-04 14:29:32] [build] make[1]: Leaving directory '/opt/src/src'
[2020-05-04 14:29:32] [build] make: *** [Makefile:34: all] Error 2
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2313#issuecomment-623874760">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZOIGH3QWYMEITBGPQDRP6VN5ANCNFSM4MYZOS7Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZPXUUDRXHQX3KZQK7TRP6VN5A5CNFSM4MYZOS72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEUXZFSA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2313#issuecomment-623874760",
"url": "https://github.com/kamailio/kamailio/pull/2313#issuecomment-623874760",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>