<p></p>
<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2295#discussion_r412853830">src/modules/siptrace/siptrace.c</a>:</p>
<pre style='color:#555'>> @@ -1383,7 +1383,7 @@ static void trace_onreq_out(struct cell *t, int type, struct tmcb_params *ps)
        }
 
        if(sip_trace_msg_attrs(msg, &sto) < 0) {
-               return;
+               goto end; 
        }
</pre>
<p>This one is in another function -- mistake?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2295#pullrequestreview-398043687">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZJFUL7EC2OC3SUFBLDRN27L7ANCNFSM4MN6SM7Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZJ3O7ZENFG2A3TQVELRN27L7A5CNFSM4MN6SM72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC642UJY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2295#pullrequestreview-398043687",
"url": "https://github.com/kamailio/kamailio/pull/2295#pullrequestreview-398043687",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>