<p></p>
<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2295#discussion_r412794186">src/modules/siptrace/siptrace.c</a>:</p>
<pre style='color:#555'>> @@ -1607,6 +1608,11 @@ static void trace_onreply_out(struct cell *t, int type, struct tmcb_params *ps)
        if(msg == NULL || msg == FAKED_REPLY) {
                msg = t->uas.request;
                faked = 1;
+               /* check if from header has been already parsed.
+                * If not we have to parse it in pkg memory and free iit at the end.
+                */
+               if (msg->from && msg->from->parsed != NULL)
</pre>
<p>Should the above condition have:</p>
<pre><code>         msg->from->parsed == NULL
</code></pre>
<p>Otherwise it should be already parsed.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2295#pullrequestreview-397975958">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZKTQZ2SL62HIRUMLPLRN2VOHANCNFSM4MN6SM7Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZPIQNKOYJHVA6CDV7DRN2VOHA5CNFSM4MN6SM72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC64KDFQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2295#pullrequestreview-397975958",
"url": "https://github.com/kamailio/kamailio/pull/2295#pullrequestreview-397975958",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>