<p></p>
<blockquote>
<p>Looks fine to me, you can merge.</p>
<p>Just a note for the archive - would probably make sense to review static int handle_ruri_alias(struct sip_msg *msg) in nathelper.c, which does a kind of similar function internally like the new added extract_alias_ip_port, to see if this could be generalized and maybe added to the core.</p>
</blockquote>
<p>Hi, I will check this function handle_ruri_alias to see if it the same functionality as the new one extract_alias_ip_port. And the idea for generalization and added the core is good.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you commented.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2246#issuecomment-610770092">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZKCBOG6NZCISSEA5WTRLQIITANCNFSM4LFZFD5Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZKW7CLWRSSW3NDCN3LRLQIITA5CNFSM4LFZFD52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOERTZZLA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2246#issuecomment-610770092",
"url": "https://github.com/kamailio/kamailio/pull/2246#issuecomment-610770092",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>