<p></p>
<p>Thanks, I am fine to merge it with one more remark.</p>
<p>Thinking a bit more about the rpc command name, I would suggest to change it to <code>dumpfile</code> or something else to suggest is writing to a file. Actually I would like to have something different that <code>dump</code> because other modules use this name to write back to rpc response. We have now a mixture between <code>list</code> and <code>dump</code> that write back to rpc response, adding a new <code>dump</code> with a different type of behaviour will make it incosistent. For example, if we add a similar command to usrloc for writing to a file, the <code>dump</code> command is already there. Let's add a name that can be (re-)used to other modules in the future, so we have some consistency from this perspective.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2272#issuecomment-610214219">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZKMADQZSSC7JQH372TRLLGBTANCNFSM4L26JTQA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZLD55UMQGL364TCEODRLLGBTA5CNFSM4L26JTQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOERPSCSY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2272#issuecomment-610214219",
"url": "https://github.com/kamailio/kamailio/pull/2272#issuecomment-610214219",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>