<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.E-MailFormatvorlage19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="mso-fareast-language:EN-US">Hi David,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">the second example looks correct:<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal">From: "14254350027" <<a href="mailto:sip%3A14254350027@1.1.18.171">sip:14254350027@1.1.18.171</a>>;tag=13133439191609<o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">the first one not (no brackets, wrong order of display name and uri.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB">From: </span><a href="mailto:sip%3A14254350027@1.1.18.171"><span lang="EN-GB">sip:14254350027@1.1.18.171</span></a><span lang="EN-GB">"14254350027" <>;tag=13133439191609<br>
<br>
</span><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Do you see this for all test calls? If yes, consider to open an issue on our github tracker about it.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Cheers,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Henning<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">-- <o:p>
</o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Henning Westerholt –
</span><span style="mso-fareast-language:EN-US"><a href="https://skalatan.de/blog/"><span lang="EN-GB" style="color:#0563C1">https://skalatan.de/blog/</span></a></span><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US">Kamailio services –
</span><span style="mso-fareast-language:EN-US"><a href="https://gilawa.com/"><span lang="EN-GB" style="color:#0563C1">https://gilawa.com</span></a></span><span style="mso-fareast-language:EN-US">
<span lang="EN-GB"><o:p></o:p></span></span></p>
<p class="MsoNormal"><span lang="EN-GB" style="mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:35.4pt"><b>From:</b> sr-dev <sr-dev-bounces@lists.kamailio.org>
<b>On Behalf Of </b>David Escartin<br>
<b>Sent:</b> Tuesday, March 3, 2020 6:10 PM<br>
<b>To:</b> Kamailio (SER) - Development Mailing List <sr-dev@lists.kamailio.org><br>
<b>Subject:</b> [sr-dev] uac_replace_from rare behaviour<o:p></o:p></p>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">Hello all<o:p></o:p></p>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">we just noticed an issue using this function<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">when we call it with 2 params (display and uri) and the SIP INVITE comes with a From uri like<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><a href="sip:anonymous@anonymous.invalid">sip:anonymous@anonymous.invalid</a>; tag=13133439191609, without <> delimiters, then doing the uac replace in the ACK we have<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"> 2(14923) DEBUG: uac [replace.c:922]: replace_callback(): DOWNSTREAM direction detected - replacing uri with the new uri<br>
2(14923) DEBUG: uac [replace.c:943]: replace_callback(): Replace [ <a href="sip:anonymous@anonymous.invalid">
sip:anonymous@anonymous.invalid</a>] with ["14254350027" <a href="mailto:sip%3A14254350027@1.1.18.171">
sip:14254350027@1.1.18.171</a>]<br>
2(14923) DEBUG: uac [replace.c:980]: replace_callback(): inserting display ["14254350027"]<br>
<br>
And this is the From header replaced<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">From: <a href="mailto:sip%3A14254350027@1.1.18.171">
sip:14254350027@1.1.18.171</a>"14254350027" <>;tag=13133439191609<br>
<br>
But if the call comes with a From header like<br>
<<a href="sip:anonymous@anonymous.invalid">sip:anonymous@anonymous.invalid</a>>; tag=13133439191609<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">Then this is the From header replaced<br>
2(19741) DEBUG: uac [replace.c:922]: replace_callback(): DOWNSTREAM direction detected - replacing uri with the new uri<br>
2(19741) DEBUG: uac [replace.c:943]: replace_callback(): Replace [ <a href="http://sip:1241342@1.1.18.171:5074">
sip:1241342@1.1.18.171:5074</a>] with ["14254350027" <a href="mailto:sip%3A14254350027@1.1.18.171">
sip:14254350027@1.1.18.171</a>]<br>
2(19741) DEBUG: uac [replace.c:980]: replace_callback(): inserting display ["14254350027"]<br>
<br>
<br>
From: "14254350027" <<a href="mailto:sip%3A14254350027@1.1.18.171">sip:14254350027@1.1.18.171</a>>;tag=13133439191609<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">Were you aware of this kind of behaviour? If possible we will look for a patch for this.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">thanks a lot and regards<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-left:35.4pt">david<o:p></o:p></p>
</div>
</div>
</div>
</body>
</html>