<p><b>@oej</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/2177#discussion_r362508638">src/modules/keepalive/keepalive_rpc.c</a>:</p>
<pre style='color:#555'>> +    return;
+}
+static const char *keepalive_rpc_get_doc[2] = {
+               "gets destination info data  from keepalive memory. usage keepalive.get sip:xx@domain listname", 0};
+
+
+static void keepalive_rpc_flush(rpc_t *rpc, void *ctx)
+{
+       ka_dest_t *dest;
+       LM_DBG("Keepalive flushes  \n");
+       ka_lock_destination_list();
+
+       for(dest = ka_destinations_list->first; dest != NULL; dest = dest->next) {
+               free_destination(dest);
+       }
+       ka_destinations_list->first = 0;
</pre>
<p>Are you sure you want to set it to "0" here? first seems to be of type ka_dest_t * so maybe NULL is better?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2177?email_source=notifications&email_token=ABO7UZKI4CBETXP7FQUDQPLQ3YAQ5A5CNFSM4J3IUNWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQQPJHQ#pullrequestreview-337704094">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZLBVXWIWBEGKZSILK3Q3YAQ5ANCNFSM4J3IUNWA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZINBPCVY3L5KT2LEK3Q3YAQ5A5CNFSM4J3IUNWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQQPJHQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2177?email_source=notifications\u0026email_token=ABO7UZKI4CBETXP7FQUDQPLQ3YAQ5A5CNFSM4J3IUNWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQQPJHQ#pullrequestreview-337704094",
"url": "https://github.com/kamailio/kamailio/pull/2177?email_source=notifications\u0026email_token=ABO7UZKI4CBETXP7FQUDQPLQ3YAQ5A5CNFSM4J3IUNWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQQPJHQ#pullrequestreview-337704094",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>