<ul>
<li>fixed a defect reported from Coverity Scan - Concurrent data access<br>
violations in spi_gen.c for spi_data->spi_val.</li>
<li>added a new conf param - ipsec_reuse_server_port - reuse or not<br>
PCSCF server port for UA Re-registration.</li>
<li>added description for the new parameter in ims_ipsec_pcscf_admin.xml.</li>
<li>in fill_contact() for Request messages set received host, port and<br>
proto fro request uri if alias is presented.</li>
<li>A new server port is used for Re-registration, depending on the new<br>
parameter ipsec_reuse_server_port.</li>
<li>in create_ipsec_tunnel() return -1 when unable to convert ip address.</li>
<li>in ipsec_forward() add supported and require secagree headers only<br>
for Register reply with code 200. Set SND_F_FORCE_SOCKET for<br>
request messages.</li>
</ul>


<h4>Pre-Submission Checklist</h4>



<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>

<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>


<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/2148'>https://github.com/kamailio/kamailio/pull/2148</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>ims_ipsec_pcscf: fixed warnings, added a new config param</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2148/files#diff-0">src/modules/ims_ipsec_pcscf/cmd.c</a>
    (209)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2148/files#diff-1">src/modules/ims_ipsec_pcscf/doc/ims_ipsec_pcscf_admin.xml</a>
    (22)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2148/files#diff-2">src/modules/ims_ipsec_pcscf/ims_ipsec_pcscf_mod.c</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/2148/files#diff-3">src/modules/ims_ipsec_pcscf/spi_gen.c</a>
    (14)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/2148.patch'>https://github.com/kamailio/kamailio/pull/2148.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/2148.diff'>https://github.com/kamailio/kamailio/pull/2148.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2148?email_source=notifications&email_token=ABO7UZJ3ZB6JKX7UEOYYC2DQVPWKZA5CNFSM4JRKYG72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H33FQ5A">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZMELNSJMBLTEUCWC6LQVPWKZANCNFSM4JRKYG7Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZIYD3JU3GNQQO7EWCDQVPWKZA5CNFSM4JRKYG72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H33FQ5A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2148?email_source=notifications\u0026email_token=ABO7UZJ3ZB6JKX7UEOYYC2DQVPWKZA5CNFSM4JRKYG72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H33FQ5A",
"url": "https://github.com/kamailio/kamailio/pull/2148?email_source=notifications\u0026email_token=ABO7UZJ3ZB6JKX7UEOYYC2DQVPWKZA5CNFSM4JRKYG72YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H33FQ5A",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>