<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>These commits create a CDR addressed engine, similar to the one that acc module exports for acc message accounting. Such an engine made an extension module like acc_json possible. This CDR engine is then used in acc_json to write the functionality for logging CDRs in JSON format.</p>
<p>I have added functions to the API exported by acc module instead of creating another separate CDR API, as I thought this is cleaner.<br>
I only implemented the acc_json logging to syslog (no message queue support yet).</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/2107'>https://github.com/kamailio/kamailio/pull/2107</a></p>
<h4>Commit Summary</h4>
<ul>
<li>acc: adding CDR engine functionality</li>
<li>acc_json: adding CDR as JSON functionality</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2107/files#diff-0">src/modules/acc/acc_api.h</a>
(38)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2107/files#diff-1">src/modules/acc/acc_cdr.c</a>
(41)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2107/files#diff-2">src/modules/acc/acc_cdr.h</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2107/files#diff-3">src/modules/acc/acc_logic.c</a>
(10)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2107/files#diff-4">src/modules/acc/acc_logic.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2107/files#diff-5">src/modules/acc/acc_mod.c</a>
(93)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2107/files#diff-6">src/modules/acc_json/acc_json_mod.c</a>
(131)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2107/files#diff-7">src/modules/acc_json/acc_json_mod.h</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/2107/files#diff-8">src/modules/acc_json/doc/acc_json_admin.xml</a>
(54)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/2107.patch'>https://github.com/kamailio/kamailio/pull/2107.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/2107.diff'>https://github.com/kamailio/kamailio/pull/2107.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2107?email_source=notifications&email_token=ABO7UZJPLFBHG3JUA3A7ITDQPXISXA5CNFSM4JC772Z2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTHLOLQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZKBBNT3OY57E64Z5I3QPXISXANCNFSM4JC772ZQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/ABO7UZJ3SQYHQUR4PTYFNDLQPXISXA5CNFSM4JC772Z2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTHLOLQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2107?email_source=notifications\u0026email_token=ABO7UZJPLFBHG3JUA3A7ITDQPXISXA5CNFSM4JC772Z2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTHLOLQ",
"url": "https://github.com/kamailio/kamailio/pull/2107?email_source=notifications\u0026email_token=ABO7UZJPLFBHG3JUA3A7ITDQPXISXA5CNFSM4JC772Z2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTHLOLQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>