<html><head></head><body><div class="ydp40cdce8ayahoo-style-wrap" style="font-family: Helvetica Neue, Helvetica, Arial, sans-serif; font-size: 13px;"><div></div>
<div dir="ltr" data-setdir="false">Perfect, thanks Henning !.<br></div><div><br></div>
</div><div id="yahoo_quoted_9797183583" class="yahoo_quoted">
<div style="font-family:'Helvetica Neue', Helvetica, Arial, sans-serif;font-size:13px;color:#26282a;">
<div>
On Wednesday, September 18, 2019, 1:45:45 PM PDT, Henning Westerholt <hw@skalatan.de> wrote:
</div>
<div><br></div>
<div><br></div>
<div><div id="yiv2866993831"><div>
<p>Hello Rupesh,</p>
<p>the lock mode was changed, you find the reasoning (and the linked commit) in this issue:</p>
<p><a rel="nofollow" shape="rect" class="yiv2866993831moz-txt-link-freetext" target="_blank" href="https://github.com/kamailio/kamailio/issues/577">https://github.com/kamailio/kamailio/issues/577</a></p>
<p>Cheers,</p>
<p>Henning<br clear="none">
</p>
<div class="yiv2866993831moz-cite-prefix">Am 18.09.19 um 22:05 schrieb Rupesh Kumar:<br clear="none">
</div>
<blockquote type="cite">
<div class="yiv2866993831yqt3043068639" id="yiv2866993831yqt74295"><div class="yiv2866993831yahoo-style-wrap" style="font-family:Helvetica Neue, Helvetica, Arial, sans-serif;font-size:13px;">
<div dir="ltr">Hi ,</div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr">Currently I am running kamailio 4.2 and now upgrading to kamailio 5.2 and was just going thru the changes.<br clear="none">
</div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr">In the file modules/usrloc/udomain.c inside the function free_udomain( ) , it appears that we are not protecting via lock_ulslot and unlock_ulslot doing free. Could it cause some race condition ?<br clear="none">
</div>
<div dir="ltr">May be its intentional but going thru the github history its there since day 1. I checked all branches in kamailio 4.x and we have the protection.</div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr">In 4.x <br clear="none">
</div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr">
<div>void free_udomain(udomain_t* _d)<br clear="none">
{<br clear="none">
int i;<br clear="none">
<br clear="none">
if (_d->table) {<br clear="none">
for(i = 0; i < _d->size; i++) {<br clear="none">
<b> lock_ulslot(_d, i);</b><br clear="none">
deinit_slot(_d->table + i);<br clear="none">
<b>unlock_ulslot(_d, i);</b><br clear="none">
}<br clear="none">
shm_free(_d->table);<br clear="none">
<div> }</div>
<div dir="ltr"> <span>shm_free(_d);</span><br clear="none">
</div>
<div>}</div>
<div><br clear="none">
</div>
<div dir="ltr">In 5.x</div>
<div dir="ltr"><br clear="none">
</div>
<div dir="ltr">
<div>void free_udomain(udomain_t* _d)<br clear="none">
{<br clear="none">
int i;<br clear="none">
<br clear="none">
if (_d->table) {<br clear="none">
for(i = 0; i < _d->size; i++) {<br clear="none">
deinit_slot(_d->table + i);<br clear="none">
}<br clear="none">
shm_free(_d->table);<br clear="none">
}<br clear="none">
shm_free(_d);<br clear="none">
}</div>
<div><br clear="none">
</div>
</div>
</div>
<div><br clear="none">
</div>
</div>
</div></div>
<br clear="none">
<fieldset class="yiv2866993831mimeAttachmentHeader"></fieldset>
<pre class="yiv2866993831moz-quote-pre">_______________________________________________
Kamailio (SER) - Users Mailing List
<a rel="nofollow" shape="rect" class="yiv2866993831moz-txt-link-abbreviated" ymailto="mailto:sr-users@lists.kamailio.org" target="_blank" href="mailto:sr-users@lists.kamailio.org">sr-users@lists.kamailio.org</a>
<a rel="nofollow" shape="rect" class="yiv2866993831moz-txt-link-freetext" target="_blank" href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users</a>
</pre>
</blockquote>
<pre class="yiv2866993831moz-signature">--
Kamailio Merchandising - <a rel="nofollow" shape="rect" class="yiv2866993831moz-txt-link-freetext" target="_blank" href="https://skalatan.de/merchandising/">https://skalatan.de/merchandising/</a>
Kamailio services - <a rel="nofollow" shape="rect" class="yiv2866993831moz-txt-link-freetext" target="_blank" href="https://skalatan.de/services">https://skalatan.de/services</a>
Henning Westerholt - <a rel="nofollow" shape="rect" class="yiv2866993831moz-txt-link-freetext" target="_blank" href="https://skalatan.de/blog/">https://skalatan.de/blog/</a></pre>
</div></div></div>
</div>
</div></body></html>