<div dir="ltr">Hi Daniel,<div>yes, sorry I meant local-response!</div><div><br></div><div>Cheers,</div><div><br></div><div>Federico</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Aug 27, 2019 at 4:19 PM Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com">miconda@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF">
<p>Hi Federico,</p>
<p>local-request stays the same (that's rather used based on mailing
list discussions).</p>
<p> I proposed to change the local-response to local-response-sent
(I don't remember any discussion about people using it, I checked
the commit log and was added by Peter Dunkley several years ago, I
never used it so far).</p>
<p>Cheers,<br>
Daniel<br>
</p>
<div class="gmail-m_-1187526521371190426moz-cite-prefix">On 27.08.19 16:04, Federico Cabiddu
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Daniel,
<div>personally I have just one case of local-request, so it
wouldn't hurt too much this change that brings consistency.</div>
<div><br>
</div>
<div>Cheers,</div>
<div><br>
</div>
<div>Federico</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Tue, Aug 27, 2019 at 1:37
PM Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hello,<br>
<br>
just discovered what I consider to be an inconsistency in
naming and<br>
behaviour for event_route blocks for local-request and
local-response<br>
and starting a discussion here to see how to move on.<br>
<br>
The event_route[tm:local-request] is executed before sending
there local<br>
generated request out (allowing also to change its content,
drop,<br>
etc...). This event route is quite popular event route used
when the<br>
local generated requests need to be checked or updates.<br>
<br>
The event_route[tm:local-response] is executed after the
response is<br>
sent out, obviously no possibility to change anymore the
content. I<br>
haven't checked the code for event_route[sl:local-response],
but based<br>
on commit message should be the same.<br>
<br>
I haven't used the local-response so far at all, today after a<br>
discussion on sr-users I wanted to enable kemi callback for<br>
tm:local-response and I noticed that behaviour in the code,
even I<br>
expected to be like local-request (before sending out).<br>
<br>
I am not sure how much used are the event routes for
tm:local-response<br>
and sl:local-response, I haven't seen any questions about them
so far on<br>
mailing lists, that's why I am asking here if would make sense
to rename<br>
them like tm:local-response-sent and sl:local-response-sent to
properly<br>
reflect when they are executed. I am expecting that they are
very few<br>
used so far, so no big head ache with upgrades and bringing
some<br>
consistency around (this change to be part of next major
release).<br>
<br>
It can stay like now with proper documentation, however in the
future if<br>
one want and event route for local responses before being sent
out,<br>
there will be more confusion, imo ...<br>
<br>
Cheers,<br>
Daniel<br>
<br>
-- <br>
Daniel-Constantin Mierla -- <a href="http://www.asipto.com" rel="noreferrer" target="_blank">www.asipto.com</a><br>
<a href="http://www.twitter.com/miconda" rel="noreferrer" target="_blank">www.twitter.com/miconda</a>
-- <a href="http://www.linkedin.com/in/miconda" rel="noreferrer" target="_blank">www.linkedin.com/in/miconda</a><br>
<br>
<br>
_______________________________________________<br>
Kamailio (SER) - Users Mailing List<br>
<a href="mailto:sr-users@lists.kamailio.org" target="_blank">sr-users@lists.kamailio.org</a><br>
<a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users" rel="noreferrer" target="_blank">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users</a><br>
</blockquote>
</div>
</blockquote>
<pre class="gmail-m_-1187526521371190426moz-signature" cols="72">--
Daniel-Constantin Mierla -- <a class="gmail-m_-1187526521371190426moz-txt-link-abbreviated" href="http://www.asipto.com" target="_blank">www.asipto.com</a>
<a class="gmail-m_-1187526521371190426moz-txt-link-abbreviated" href="http://www.twitter.com/miconda" target="_blank">www.twitter.com/miconda</a> -- <a class="gmail-m_-1187526521371190426moz-txt-link-abbreviated" href="http://www.linkedin.com/in/miconda" target="_blank">www.linkedin.com/in/miconda</a></pre>
</div>
</blockquote></div>