<p><b>@gaaf</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1832#discussion_r303425969">src/modules/dialog/dlg_handlers.c</a>:</p>
<pre style='color:#555'>> @@ -269,6 +271,25 @@ int populate_leg_info( struct dlg_cell *dlg, struct sip_msg *msg,
 
        if (rr_set.s) pkg_free(rr_set.s);
</pre>
<p>print_rr_body() allocates the memory for rrset.s, it is up to the caller to free it. As it may be allocated twice, it must be freed twice and that must be done before the next call to print_rr_body(). Each free is in the same scope as the call to print_rr_body(). I fail to see how these can be combined into one free.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1832?email_source=notifications&email_token=ABO7UZMUWBRQYMCBO7T2XWLP7RZKLA5CNFSM4GTY76Q2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6NN3XI#discussion_r303425969">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZL34AJV4FJXRNGANM3P7RZKLANCNFSM4GTY76QQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABO7UZNGG245E67475DOLTLP7RZKLA5CNFSM4GTY76Q2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6NN3XI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1832?email_source=notifications\u0026email_token=ABO7UZMUWBRQYMCBO7T2XWLP7RZKLA5CNFSM4GTY76Q2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6NN3XI#discussion_r303425969",
"url": "https://github.com/kamailio/kamailio/pull/1832?email_source=notifications\u0026email_token=ABO7UZMUWBRQYMCBO7T2XWLP7RZKLA5CNFSM4GTY76Q2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6NN3XI#discussion_r303425969",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>