<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=610755" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/tdimitrov">@tdimitrov</a> I started the review yesterday as announced here, but got caught by some other urgent topic. This is a quite large patch in the end. There was no need to rush this into the repository.</p>
<p>There exists many white-space issues where the code uses a complete different indention as the existing code (e.g. ims_ipsec_pcscf_mod.c). There are also several commented out code blocks which should be probably removed as well (src/modules/ims_ipsec_pcscf/ipsec.c). I will have a look to fix the most noticeable cases.</p>
<p>If you like to merge a big patch like this in the future, please spend some time to review the code to catch this obvious issues before.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/2001?email_source=notifications&email_token=ABO7UZLLBYKGR3343JSM4U3P7S55VA5CNFSM4H5U7EOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6RPWA#issuecomment-511514584">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZPK4TMVFEHFTO5DAPDP7S55VANCNFSM4H5U7EOA">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABO7UZKHU5JC5DAAVMURVBTP7S55VA5CNFSM4H5U7EOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6RPWA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/2001?email_source=notifications\u0026email_token=ABO7UZLLBYKGR3343JSM4U3P7S55VA5CNFSM4H5U7EOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6RPWA#issuecomment-511514584",
"url": "https://github.com/kamailio/kamailio/pull/2001?email_source=notifications\u0026email_token=ABO7UZLLBYKGR3343JSM4U3P7S55VA5CNFSM4H5U7EOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ6RPWA#issuecomment-511514584",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>