<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="426063789" data-permission-text="Issue title is private" data-url="https://github.com/kamailio/kamailio/issues/1911" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/1911/hovercard" href="https://github.com/kamailio/kamailio/issues/1911">#1911</a></li>
</ul>
<h4>Description</h4>
<p>The goal was to have a different, more complex hashing algorithm that would offer a better distribution among nodes. We've seen in production that the current algorithm does not perform well under heavy load therefore we decided to add SHA1 hashing. After running performance tests we've decided that we need a cryptographic function in order to have the best results mostly when the callids have small entropy.<br>
In order to add SHA1, a new API was added in crypto module exporting a function applying SHA1 to a string. The API was used in rtpengine module over the callid. After this operation the hash was calculated as before except for applying 0xFF mask over the hash as it was done before, which restrains the power of this algorithm.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1986'>https://github.com/kamailio/kamailio/pull/1986</a></p>
<h4>Commit Summary</h4>
<ul>
<li>crypto: add exportable API and expose SHA1 hashing function</li>
<li>rtpengine: use SHA1 over callid for better distribution among nodes</li>
<li>rtpengine: add modparam to switch between legacy hashing algorithm and SHA1</li>
<li>rtpengine: update README</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/1986/files#diff-0">src/modules/crypto/api.c</a>
(30)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/kamailio/kamailio/pull/1986/files#diff-1">src/modules/crypto/api.h</a>
(63)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1986/files#diff-2">src/modules/crypto/crypto_mod.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1986/files#diff-3">src/modules/crypto/crypto_uuid.c</a>
(34)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1986/files#diff-4">src/modules/crypto/crypto_uuid.h</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1986/files#diff-5">src/modules/rtpengine/doc/rtpengine_admin.xml</a>
(25)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1986/files#diff-6">src/modules/rtpengine/rtpengine.c</a>
(53)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1986/files#diff-7">src/modules/rtpengine/rtpengine.h</a>
(1)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1986.patch'>https://github.com/kamailio/kamailio/pull/1986.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1986.diff'>https://github.com/kamailio/kamailio/pull/1986.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1986?email_source=notifications&email_token=ABO7UZJMMEDL4FVBFNPCULLP3HWTZA5CNFSM4HZHIEB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G2KXPZQ">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZKCY54ONPBT4QYLRWDP3HWTZANCNFSM4HZHIEBQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABO7UZPPBQDLHTOOOLIJ4ETP3HWTZA5CNFSM4HZHIEB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G2KXPZQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1986?email_source=notifications\u0026email_token=ABO7UZJMMEDL4FVBFNPCULLP3HWTZA5CNFSM4HZHIEB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G2KXPZQ",
"url": "https://github.com/kamailio/kamailio/pull/1986?email_source=notifications\u0026email_token=ABO7UZJMMEDL4FVBFNPCULLP3HWTZA5CNFSM4HZHIEB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G2KXPZQ",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>