<p><b>@alexyosifov</b> commented on this pull request.</p>
<blockquote>
<blockquote>
<blockquote>
<p>Great work, just a small notice, there is a committed Readme file.</p>
</blockquote>
<p>Thanks,<br>
The committed README file is regenerated, not manually changed.</p>
</blockquote>
<p>Yes, but please remove the changes to the README file from your pull request. :-) This is not needed, the README is autogenerated from a script in our infrastructure after every change.</p>
</blockquote>
<p>Done.</p><hr>
<p>In <a href="https://github.com/kamailio/kamailio/pull/1974#discussion_r290596070">src/modules/ims_ipsec_pcscf/cmd.c</a>:</p>
<pre style='color:#555'>> @@ -562,6 +560,24 @@ int ipsec_forward(struct sip_msg* m, udomain_t* d)
struct pcontact_info ci;
pcontact_t* pcontact = NULL;
int ret = IPSEC_CMD_FAIL; // FAIL by default
+ unsigned char dst_proto = PROTO_UDP;
</pre>
<p>It's not an error, just default value.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1974?email_source=notifications&email_token=ABO7UZND4SW4C4VWUTPCIOLPY5N3LA5CNFSM4HSZHHV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2TQI3Y#pullrequestreview-245826671">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZIWCUUXU65LFJIBVA3PY5N3LANCNFSM4HSZHHVQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABO7UZNXAIBJYS3W5IZXDW3PY5N3LA5CNFSM4HSZHHV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2TQI3Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1974?email_source=notifications\u0026email_token=ABO7UZND4SW4C4VWUTPCIOLPY5N3LA5CNFSM4HSZHHV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2TQI3Y#pullrequestreview-245826671",
"url": "https://github.com/kamailio/kamailio/pull/1974?email_source=notifications\u0026email_token=ABO7UZND4SW4C4VWUTPCIOLPY5N3LA5CNFSM4HSZHHV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2TQI3Y#pullrequestreview-245826671",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>