<p><b>@henningw</b> commented on this pull request.</p>

<p>Thank you, great that you could get rid of the serialization/de-serialization code. I had only two small remarks to the pull request. I think it can be merged, you can work on that also directly in the repository.</p><hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1963#discussion_r287127872">src/modules/siptrace/siptrace.c</a>:</p>
<pre style='color:#555'>>  
                /* could use the dest_info we've already parsed but there's no way to pass
                 * it to DLGCB_CREATED callback so the only thing to do is keep
                 * it as uri, serialize in a dlg_var and parse again in DLGCB_CREATED */
                if(corid) {
-                       info->correlation_id = *corid;
+                       info->correlation_id.s = (char *)(info + 1);
</pre>
<p>Maybe I misunderstood the code here, but why you use +1? If you want to increment the pointer for siptrace_info_t length, maybe use sizeof?</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1963#discussion_r287128111">src/modules/siptrace/siptrace.c</a>:</p>
<pre style='color:#555'>> @@ -133,8 +132,8 @@ static str direction_column = str_init("direction");    /* 09 */
 static str time_us_column = str_init("time_us");              /* 10 */
 static str totag_column = str_init("totag");                  /* 11 */
 
-static str siptrace_info_dlgkey = str_init("__siptrace_info_dlg_key__");
-static str siptrace_info_avp_str = str_init("$avp(__siptrace_info_avp__)");
+#define XAVP_TRACE_INFO_NAME "trace_info"
</pre>
<p>Would be good to document this as well in the README, to prevent accidential overlapping with existing xavps.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1963?email_source=notifications&email_token=ABO7UZIHDDWCT33TOA5R2K3PW4BGXA5CNFSM4HOVADQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZSB7OI#pullrequestreview-241442745">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZOSQSLRGQLVFTS236LPW4BGXANCNFSM4HOVADQQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABO7UZOT36HSN4PKR6LG2WLPW4BGXA5CNFSM4HOVADQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZSB7OI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1963?email_source=notifications\u0026email_token=ABO7UZIHDDWCT33TOA5R2K3PW4BGXA5CNFSM4HOVADQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZSB7OI#pullrequestreview-241442745",
"url": "https://github.com/kamailio/kamailio/pull/1963?email_source=notifications\u0026email_token=ABO7UZIHDDWCT33TOA5R2K3PW4BGXA5CNFSM4HOVADQ2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZSB7OI#pullrequestreview-241442745",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>