<p>There are already functions to parse a string to ip struct for ipv4 and ipv4, see str2ip() and str2ip6() in <code>src/core/resolve.h </code>. In that struct you have the <code>af</code> field. In most of the code, the two functions were used one after the other to parse ip addresses, if str2ip() fails, then try str2ip6().</p>
<p>We can add a new function str2ipx() as a wrapper to this logic, but otherwise, I see no reason to add the new functions proposed by your pull request.</p>
<p>Also, the one for trimming <code>[ ]</code> for ipv6 with copy over is not that useful in a global scope from my point of view. Moreover, there are no safety checks over the size of the target pointer, nor comments requesting a minimum value for that. This can be in the module that needs it.</p>
<p>I am closing this PR without merge. If people want to discuss more, then keep adding comments and if it is decided, it can be reopened.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1962?email_source=notifications&email_token=ABO7UZO6LSTTMJ7VRROLLD3PWUAPFA5CNFSM4HORYW32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV6KKBI#issuecomment-494707973">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABO7UZOJMXUORJ44BTKKFGDPWUAPFANCNFSM4HORYW3Q">mute the thread</a>.<img src="https://github.com/notifications/beacon/ABO7UZJ65GJIKF2WKKI76SLPWUAPFA5CNFSM4HORYW32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV6KKBI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1962?email_source=notifications\u0026email_token=ABO7UZO6LSTTMJ7VRROLLD3PWUAPFA5CNFSM4HORYW32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV6KKBI#issuecomment-494707973",
"url": "https://github.com/kamailio/kamailio/pull/1962?email_source=notifications\u0026email_token=ABO7UZO6LSTTMJ7VRROLLD3PWUAPFA5CNFSM4HORYW32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV6KKBI#issuecomment-494707973",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>