<p><b>@ionutionita92</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1912#discussion_r273000051">src/modules/siptrace/siptrace.c</a>:</p>
<pre style='color:#555'>>  
-       pkg_free(*param);
-       /* free temporary proxy*/
-       if(p) {
-               free_proxy(p); /* frees only p content, not p itself */
-               pkg_free(p);
+               trace_type = parse_siptrace_flag(&sflags);
+               if (trace_type == SIPTRACE_NONE) {
+                       LM_ERR("Failed to parse trace type!\n");
+                       return -1;
+               }
+
+               *param = pkg_malloc(sizeof(trace_type));
</pre>
<p>Thanks for this one.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1912#discussion_r273000051">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZVAf6r_-dlXgqmxZO5bzTdKzTSf_ks5veyiegaJpZM4cP-3E">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zexm0X-lXm2GnhbVsZeyaUv05PWOks5veyiegaJpZM4cP-3E.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ionutionita92 commented on #1912"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1912#discussion_r273000051"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1912#discussion_r273000051",
"url": "https://github.com/kamailio/kamailio/pull/1912#discussion_r273000051",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>