<p><b>@henningw</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1912#discussion_r273206034">src/modules/siptrace/siptrace.c</a>:</p>
<pre style='color:#555'>> @@ -304,10 +338,30 @@ static int mod_init(void)
        /* register callbacks to TM */
        if(load_tm_api(&tmb) != 0) {
                LM_WARN("can't load tm api. Will not install tm callbacks.\n");
-       } else if(tmb.register_tmcb(0, 0, TMCB_REQUEST_IN, trace_onreq_in, 0, 0)
-                         <= 0) {
-               LM_ERR("can't register trace_onreq_in\n");
-               return -1;
+       }
+
+       if (load_dlg_api(&dlgb) < 0) {
+               LM_WARN("can't load dlg api. Will not install dialog callbacks.\n");
</pre>
<p>It was only a minor comment. But having though about one more time its makes sense now with your comment.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1912#discussion_r273206034">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZSwh-TpSAvXihHsOOCygSAIliDH7ks5ve5pQgaJpZM4cP-3E">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zb94PCf3J0bvohvpGuVKJp-NLViWks5ve5pQgaJpZM4cP-3E.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@henningw commented on #1912"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1912#discussion_r273206034"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1912#discussion_r273206034",
"url": "https://github.com/kamailio/kamailio/pull/1912#discussion_r273206034",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>