<p>Everything is ready, I added trace flag back. Moreover I fixed a bug in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/1cd0aaade45872a38f26b60e5af985006c26f9b1/hovercard" href="https://github.com/kamailio/kamailio/commit/1cd0aaade45872a38f26b60e5af985006c26f9b1"><tt>1cd0aaa</tt></a>, <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/688b258ce7a3561725af7857aa973bf11fd6fba0/hovercard" href="https://github.com/kamailio/kamailio/commit/688b258ce7a3561725af7857aa973bf11fd6fba0"><tt>688b258</tt></a> and <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/16f24e482c2584dac0b227c2ebbaddb4915ba777/hovercard" href="https://github.com/kamailio/kamailio/commit/16f24e482c2584dac0b227c2ebbaddb4915ba777"><tt>16f24e4</tt></a>. What happened: if modparam duplicate uri was not defined but siptrace uri param was defined messages were not traced because of a bogus condition in siptrace_send.c. Also, in this scenari, the code(which is useless for that scenario) removed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/200acfa2a94ab77c5b44692cc2399fc71a001969/hovercard" href="https://github.com/kamailio/kamailio/commit/200acfa2a94ab77c5b44692cc2399fc71a001969"><tt>200acfa</tt></a> would have crashed if the condition was fixed.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1912#issuecomment-480312794">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZUjJ4Osq9be8z0lUBnp64ljwuUimks5vd2flgaJpZM4cP-3E">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZbnGbDkkOu0nk4t7ntvo7C_clmt1ks5vd2flgaJpZM4cP-3E.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ionutionita92 in #1912: Everything is ready, I added trace flag back. Moreover I fixed a bug in https://github.com/kamailio/kamailio/pull/1912/commits/1cd0aaade45872a38f26b60e5af985006c26f9b1, https://github.com/kamailio/kamailio/pull/1912/commits/688b258ce7a3561725af7857aa973bf11fd6fba0 and https://github.com/kamailio/kamailio/pull/1912/commits/16f24e482c2584dac0b227c2ebbaddb4915ba777. What happened: if modparam duplicate uri was not defined but siptrace uri param was defined messages were not traced because of a bogus condition in siptrace_send.c. Also, in this scenari, the code(which is useless for that scenario) removed in https://github.com/kamailio/kamailio/pull/1912/commits/200acfa2a94ab77c5b44692cc2399fc71a001969 would have crashed if the condition was fixed."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1912#issuecomment-480312794"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1912#issuecomment-480312794",
"url": "https://github.com/kamailio/kamailio/pull/1912#issuecomment-480312794",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>