<p>Change in ims_isc/checker.c and ims_isc/checker.h:<br>
add to isc_match two new flags include_register_request<br>
and include_register_response in addition to service_info<br>
Both info are retrieved from HSS during SAR/SAA<br>
Change in ims_isc/third_party_reg.c/.h:<br>
Add REGISTER Request or REGISTER Response or Service Info<br>
to the body of the REGISTER message that is sent to the<br>
AS, if it is requested by content of HSS (SAR/SAA)<br>
Change in ims_registrar_scscf/userdata_parser.c and<br>
ims_usrloc_scscf/usrloc.h:<br>
Parse the additional flags, when they are received from HSS<br>
and store in the subscription.</p>
<p>Conflicts:<br>
src/modules/ims_isc/third_party_reg.c<br>
src/modules/ims_rdn/userdata_parser.c</p>
<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commits are split per component (core, individual modules, libs, utils, ...)<br>
---> apologies, we did this commit long ago, when we did not know the rules of the project<br>
main changes are in ims_isc, two small changes in ims_registrar_scscf and ims_usrloc_scscf</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally based on a local branch derived from 5.1.0</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>The feature is a small add-on to third party registration in S-CSCF<br>
The feature assumes two new flags in HSS database, where additional to the "Service Info XML" an "insertRegisterRequest" flag or an "insertRegisterRepsonse" flag can be set. These flags are sent with the SAR/SAA exchange to the S-CSCF, where the new feature does a prioritization:<br>
If Service Info present -> add service info to body of 3rd Party REGISTER Request<br>
else if insertRegisterRequest -> add original REGISTER request to body of 3rd Party REGISTER request<br>
else if insertRegisterResponse -> add original REGISTER response to body of 3rd Party REGISTER request<br>
else -> add no body to 3rd Party REGISTER request.<br>
Multipart Body is not supported.<br>
More info about the insertRegisterRequest and insertRegisterResponse flags can be found in applicable 3GPP standards.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1923'>https://github.com/kamailio/kamailio/pull/1923</a></p>
<h4>Commit Summary</h4>
<ul>
<li>ims_isc: add-on for third-party registration</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1923/files#diff-0">src/modules/ims_isc/checker.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1923/files#diff-1">src/modules/ims_isc/checker.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1923/files#diff-2">src/modules/ims_isc/third_party_reg.c</a>
(106)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1923/files#diff-3">src/modules/ims_isc/third_party_reg.h</a>
(18)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1923/files#diff-4">src/modules/ims_registrar_scscf/userdata_parser.c</a>
(35)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1923/files#diff-5">src/modules/ims_usrloc_scscf/usrloc.h</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1923.patch'>https://github.com/kamailio/kamailio/pull/1923.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1923.diff'>https://github.com/kamailio/kamailio/pull/1923.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1923">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZTRuTCVXdGzEpfRW-pI3_likfumuks5vdhu2gaJpZM4cdGof">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZaAl8yFp5n_285nEgwKhwDcuBM8Eks5vdhu2gaJpZM4cdGof.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"ims_isc: add-on for third-party registration (#1923)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1923"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1923",
"url": "https://github.com/kamailio/kamailio/pull/1923",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>