<p><b>@grumvalski</b> commented on this pull request.</p>

<p>Thanks!<br>
Looks fine, just a small comment on the doc.</p><hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1912#discussion_r271168586">src/modules/siptrace/doc/siptrace_admin.xml</a>:</p>
<pre style='color:#555'>> @@ -656,6 +654,11 @@ hlog("$hdr(P-MyID)", "Another one with a custom correlation ID");
        Stateless forwarded messages (forward()) are not logged if you set the
        flag, use sip_trace() inside <emphasis>onsend_route</emphasis> block.
        </para>
+       <para>
+       If dialog level tracing is used internally generated BYE transaction(in
+       case of internal timeouts) won't be traced. At the moment kamailio offers
+       no posibility to trace those messages.
</pre>
<p>Actually it should be possible to capture these BYEs, as we do for ACK, in onsend_route or in tm's module local_route.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1912#pullrequestreview-221492084">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZSsssghlC-3nWRLclWUyQm7cAqiOks5vcwnkgaJpZM4cP-3E">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZXAxU6ylGnSu1crRX4MIKFyaOI_6ks5vcwnkgaJpZM4cP-3E.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@grumvalski commented on #1912"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1912#pullrequestreview-221492084"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1912#pullrequestreview-221492084",
"url": "https://github.com/kamailio/kamailio/pull/1912#pullrequestreview-221492084",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>