You're right, I missed it sorry.<br>
<br>
Federico<br>
<br>
On Fri, Mar 29, 2019 at 9:36 AM Daniel-Constantin Mierla <<br>
notifications@github.com> wrote:<br>
<br>
> @samael33 <https://github.com/samael33>, @grumvalski<br>
> <https://github.com/grumvalski> -- the commit messages on this pull are<br>
> really inappropriate for development history.<br>
><br>
> Next time check the contribution guidelines:<br>
><br>
>    -<br>
>    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md<br>
><br>
> —<br>
> You are receiving this because you were mentioned.<br>
> Reply to this email directly, view it on GitHub<br>
> <https://github.com/kamailio/kamailio/pull/1913#issuecomment-477914492>,<br>
> or mute the thread<br>
> <https://github.com/notifications/unsubscribe-auth/ADip4799S3PxRSOVf5QUkkj4SAjbiatkks5vbdCYgaJpZM4cQJrV><br>
> .<br>
><br>


<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1913#issuecomment-477921080">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZTzg1GVOnn7FP8ANnUjhM30KWJ7Hks5vbdYjgaJpZM4cQJrV">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZboXgMXckmOC-Mq55rwPIbw_6v2iks5vbdYjgaJpZM4cQJrV.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@grumvalski in #1913: You're right, I missed it sorry.\n\nFederico\n\nOn Fri, Mar 29, 2019 at 9:36 AM Daniel-Constantin Mierla \u003c\nnotifications@github.com\u003e wrote:\n\n\u003e @samael33 \u003chttps://github.com/samael33\u003e, @grumvalski\n\u003e \u003chttps://github.com/grumvalski\u003e -- the commit messages on this pull are\n\u003e really inappropriate for development history.\n\u003e\n\u003e Next time check the contribution guidelines:\n\u003e\n\u003e    -\n\u003e    https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md\n\u003e\n\u003e —\n\u003e You are receiving this because you were mentioned.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/kamailio/kamailio/pull/1913#issuecomment-477914492\u003e,\n\u003e or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/ADip4799S3PxRSOVf5QUkkj4SAjbiatkks5vbdCYgaJpZM4cQJrV\u003e\n\u003e .\n\u003e\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1913#issuecomment-477921080"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1913#issuecomment-477921080",
"url": "https://github.com/kamailio/kamailio/pull/1913#issuecomment-477921080",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>