<p><b>@grumvalski</b> commented on this pull request.</p>
<p>Thank you!<br>
Just a small comment on the PR.</p><hr>
<p>In <a href="https://github.com/kamailio/kamailio/pull/1913#discussion_r270054598">src/modules/http_async_client/doc/http_async_client_admin.xml</a>:</p>
<pre style='color:#555'>> @@ -435,7 +435,7 @@ xlog("L_INFO", "received reply for query $http_req_id\n");
<listitem><para><emphasis>hdr</emphasis>: sets/modifies/removes a HTTP header. N.B.: setting this variable multiple times will add several headers to the query.</para></listitem>
<listitem><para><emphasis>body</emphasis>: sets/modifies/removes the request body</para></listitem>
<listitem><para><emphasis>method</emphasis>: sets the HTTP method: either "GET", "POST", "PUT" or "DELETE" (these are the supported methods). (Note: if the method is not set, curl will use GET, or POST if a body is specified)</para></listitem>
- <listitem><para><emphasis>timeout</emphasis>: sets the HTTP timeout</para></listitem>
+ <listitem><para><emphasis>timeout</emphasis>: sets the HTTP timeout. (Note, this timeout should be normally less, than <literal>tm.fr_timer</literal> timeout, cause transaction timeout has a higher priority over HTTP timeout)</para></listitem>
</pre>
<p>s/cause/because/<br>
and<br>
s/less,/less/</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1913#pullrequestreview-220087253">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZbiTbHc1L9U-0FSKvGSz6YEA76xxks5vbNyGgaJpZM4cQJrV">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZcpeU6_l52NGPeUhfWwMG_KSlkEwks5vbNyGgaJpZM4cQJrV.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@grumvalski commented on #1913"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1913#pullrequestreview-220087253"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1913#pullrequestreview-220087253",
"url": "https://github.com/kamailio/kamailio/pull/1913#pullrequestreview-220087253",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>