<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>Siptrace module has two different tracing concepts which do mostly the same thing. It has sip_trace function and it has trace_flag parameter which traces messages in a transaction. This pull request aims to have a single point of trace activation, that is when the user calls sip_trace() function from the script. Moreover, it adds 3 levels of tracing: message, transaction and dialog level tracing. This option is added as a parameter to sip_trace(), therefore the user can now summon sip_trace(duri, correlation_id, "m/t/d") where "m" stands for message, "t" for transaction and "d" for dialog.</p>
<p>The patch has been tested both locally and in our company's test system. Locally I've tested it using a few scenarios generated using sipp: successful call, negative reply(491 answer - hop-by-hop ACK), UAC CANCEL and dual bye scenario generated by Kamailio(dialog timeout). The only issue with current patch is it doesn't trace internally generated BYEs that is because they are only a buffer in Kamailio, not a parsed SIP message, therefore, after a few days of searching for solutions I didn't find any valid one. Parsing a SIP message for tracing didn't seem worth the processing time to me, but of course it can be added in the future.</p>
<p>Looking forward to your opinion or suggestions regarding the current patch.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1912'>https://github.com/kamailio/kamailio/pull/1912</a></p>
<h4>Commit Summary</h4>
<ul>
<li>siptrace: add basic transaction and dialog level tracing</li>
<li>siptrace: trace negative ACKs</li>
<li>siptrace: check if a request is set to avoid local transaction crash</li>
<li>siptrace: Add code to trace incoming CANCEL transcations</li>
<li>siptrace: Minor code fixes; remove useless error logs</li>
<li>siptrace: store sip_trace destination parameter for the entire dialog</li>
<li>siptrace: remove unused trace flag</li>
<li>siptrace: update README</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1912/files#diff-0">src/core/parser/msg_parser.h</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1912/files#diff-1">src/modules/siptrace/README</a>
(562)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1912/files#diff-2">src/modules/siptrace/doc/siptrace_admin.xml</a>
(33)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1912/files#diff-3">src/modules/siptrace/siptrace.c</a>
(864)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1912/files#diff-4">src/modules/siptrace/siptrace_data.h</a>
(14)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1912.patch'>https://github.com/kamailio/kamailio/pull/1912.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1912.diff'>https://github.com/kamailio/kamailio/pull/1912.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1912">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZV0JVGbcqrXkU2PQTukSeYvVmVu5ks5vbK47gaJpZM4cP-3E">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zf7S8f0nDD5UXikwz2ZRqKbi4Wf8ks5vbK47gaJpZM4cP-3E.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Siptrace (#1912)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1912"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1912",
"url": "https://github.com/kamailio/kamailio/pull/1912",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>