<p>This one is not going to be merged, the reasons:</p>
<ul>
<li>first see my comment in the other PR: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="424393334" data-permission-text="Issue title is private" data-url="https://github.com/kamailio/kamailio/issues/1903" data-hovercard-type="pull_request" data-hovercard-url="/kamailio/kamailio/pull/1903/hovercard?comment_id=475956037&comment_type=issue_comment" href="https://github.com/kamailio/kamailio/pull/1903#issuecomment-475956037">#1903 (comment)</a></li>
<li>using separate <code>=~</code> has not benefits, actually can be slower than using a single regex matching. If it gets too long, could make sense split in groups of matches to avoid long lines and have better readibility, but not one match per possible user-agent.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1905#issuecomment-475956317">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZS-2WhRY5tFcsRaGs2EJjKLF2wl-ks5vZ3YfgaJpZM4cFbet">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zb6NQ7OOyMefRb_au39zcaWVAEKtks5vZ3YfgaJpZM4cFbet.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1905: This one is not going to be merged, the reasons:\r\n\r\n  * first see my comment in the other PR: https://github.com/kamailio/kamailio/pull/1903#issuecomment-475956037\r\n  * using separate `=~` has not benefits, actually can be slower than using a single regex matching. If it gets too long, could make sense split in groups of matches to avoid long lines and have better readibility, but not one match per possible user-agent."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1905#issuecomment-475956317"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1905#issuecomment-475956317",
"url": "https://github.com/kamailio/kamailio/pull/1905#issuecomment-475956317",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>